Attention is currently required from: Hoernchen, dexter. lynxis lazus has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/40468?usp=email ) Change subject: smdpp: less verbose by default ...................................................................... Patch Set 6: (4 comments) File osmo-smdpp.py: https://gerrit.osmocom.org/c/pysim/+/40468/comment/fe755d09_6e09e9cf?usp=em… : PS6, Line 112: #print("Using nameConstraints parsing for variant O certificate") Should this debug? Or not could you drop the line? https://gerrit.osmocom.org/c/pysim/+/40468/comment/d910e1e8_ea275842?usp=em… : PS6, Line 117: #print("Using GSMA permittedEins parsing for newer certificate variant") Should this debug? Or not could you drop the line? https://gerrit.osmocom.org/c/pysim/+/40468/comment/8ab4caee_de9dd93b?usp=em… : PS6, Line 362: #logger.debug("Rx JSON: %s" % json.dumps(content)) logger.debug()? or remove the line? https://gerrit.osmocom.org/c/pysim/+/40468/comment/20fed223_eb34ca1a?usp=em… : PS6, Line 370: logger.debug("Tx JSON: %s" % json.dumps(output)[:200]) Is this an expensive operations because the object is huge (json.dumps)? You could use `logger.debug("foo %s", foo), the logger will do the string replacement if debug is enabled. To save the json.dumps() in case debug is not present, you could hide it behind an if. `if logger.isEnabledFor(logging.DEBUG): logger.debug("Tx JSON: %s" % json.dumps(output)[:200]) ` -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40468?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I04a72b8f52417862d4dcba1f0743700dd942ef49 Gerrit-Change-Number: 40468 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 01 Jul 2025 13:08:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No