Attention is currently required from: Hoernchen, dexter.

View Change

4 comments:

• File osmo-smdpp.py:

  • Patch Set #6, Line 112: #print("Using nameConstraints parsing for variant O certificate")

    Should this debug? Or not could you drop the line?

  • Patch Set #6, Line 117: #print("Using GSMA permittedEins parsing for newer certificate variant")

    Should this debug? Or not could you drop the line?

  • Patch Set #6, Line 362: #logger.debug("Rx JSON: %s" % json.dumps(content))

    logger.debug()? or remove the line?

  • Patch Set #6, Line 370: logger.debug("Tx JSON: %s" % json.dumps(output)[:200])

    Is this an expensive operations because the object is huge (json.dumps)?

    You could use `logger.debug("foo %s", foo), the logger will do the string replacement if debug is enabled.
    To save the json.dumps() in case debug is not present, you could hide it behind an if.

    `if logger.isEnabledFor(logging.DEBUG):
       logger.debug("Tx JSON: %s" % json.dumps(output)[:200])
    `

To view, visit change 40468. To unsubscribe, or for help writing mail filters, visit settings.