Jenkins Builder has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email ) Change subject: Add functions to set LAC/CI on a BTS and update hashtables. ...................................................................... Patch Set 2: (8 comments) File src/osmo-bsc/bts.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/3cc40e25_2887aa1c?usp… : PS2, Line 761: int gsm_bts_set_lac(struct gsm_bts *bts, int lac) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/4b4bd1ea_5f765708?usp… : PS2, Line 772: int gsm_bts_set_ci(struct gsm_bts *bts, int ci) { open brace '{' following function definitions go on the next line File src/osmo-bsc/bts_ctrl.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/3389c0f8_40d71919?usp… : PS2, Line 247: static int get_bts_lac(struct ctrl_cmd *cmd, void *data) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/c5542973_492f7f35?usp… : PS2, Line 257: static int set_bts_lac(struct ctrl_cmd *cmd, void *data) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/54ce82f7_d3198bfb?usp… : PS2, Line 266: static int verify_bts_lac(struct ctrl_cmd *cmd, const char *value, void *data) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/dd2fa18e_da922bdd?usp… : PS2, Line 280: static int get_bts_ci(struct ctrl_cmd *cmd, void *data) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/35267f88_460e39e5?usp… : PS2, Line 290: static int set_bts_ci(struct ctrl_cmd *cmd, void *data) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/3aae866f_79c1f532?usp… : PS2, Line 299: static int verify_bts_ci(struct ctrl_cmd *cmd, const char *value, void *data) { open brace '{' following function definitions go on the next line -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If9509534bd4a75f8ed8fb3e0a6bec701c7596861 Gerrit-Change-Number: 40917 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 25 Aug 2025 20:34:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No