Attention is currently required from: roox, laforge, tnt. manawyrm has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27837 ) Change subject: octoi: slip frames if RIFO runs empty in IP->E1 direction ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: Looking at the unit tests: ``` TEST: correct_order, starting at FN: 0 RIFO_IN(0000000000000000000000000000000000000000000000000000000000000000, 0)=0 RIFO_IN(0101010101010101010101010101010101010101010101010101010101010101, 1)=0 RIFO_IN(0202020202020202020202020202020202020202020202020202020202020202, 2)=0 RIFO_IN(0303030303030303030303030303030303030303030303030303030303030303, 3)=0 RIFO_IN(0404040404040404040404040404040404040404040404040404040404040404, 4)=0 RIFO_IN(0505050505050505050505050505050505050505050505050505050505050505, 5)=0 RIFO_IN(0606060606060606060606060606060606060606060606060606060606060606, 6)=0 RIFO_IN(0707070707070707070707070707070707070707070707070707070707070707, 7)=0 RIFO_IN(0808080808080808080808080808080808080808080808080808080808080808, 8)=0 RIFO_IN(0909090909090909090909090909090909090909090909090909090909090909, 9)=0 RIFO_OUT(0000000000000000000000000000000000000000000000000000000000000000)=0 RIFO_OUT(0101010101010101010101010101010101010101010101010101010101010101)=0 RIFO_OUT(0202020202020202020202020202020202020202020202020202020202020202)=0 RIFO_OUT(0303030303030303030303030303030303030303030303030303030303030303)=0 RIFO_OUT(0404040404040404040404040404040404040404040404040404040404040404)=0 RIFO_OUT(0505050505050505050505050505050505050505050505050505050505050505)=0 RIFO_OUT(0606060606060606060606060606060606060606060606060606060606060606)=0 RIFO_OUT(0707070707070707070707070707070707070707070707070707070707070707)=0 RIFO_OUT(0808080808080808080808080808080808080808080808080808080808080808)=0 RIFO_OUT(ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff)=-2 ``` This doesn't seem quite right? There are some other oddities in there. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27837 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ic2a714fedb9a0698c17ef22447904a803c26ebfc Gerrit-Change-Number: 27837 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: roox <mardnh(a)gmx.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: roox <mardnh(a)gmx.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Tue, 19 Apr 2022 22:19:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment