Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33599 ) Change subject: ASCI: Add support for Group/Broadcast channel activation ...................................................................... Patch Set 3: (2 comments) File include/osmocom/bsc/lchan.h: https://gerrit.osmocom.org/c/osmo-bsc/+/33599/comment/c7735630_94a77a6f PS3, Line 142: see also my comment below. It's not valid to have more than one of the vamos, vgcs, vbs booleans set, so it might be better to have an enum or something... File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/33599/comment/344cf2fe_2af6113b PS3, Line 408: bool vamos, bool vgcs, bool vbs) it's a bit odd that we pass multiple separate bool variables in here, where in reality only one of those can be ever set. So either we have to add OSMO_ASSERT() to make sure we never are called with multiple of those bool's set, or we introduce some kind of enum where the caller can chose either VAMOS or VGCS or VBS, but not set multiple at the same time. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic0c0597d149d0758d6766937d99660fa02e0e139 Gerrit-Change-Number: 33599 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 10 Jul 2023 18:18:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment