Attention is currently required from: jolly.
2 comments:
File include/osmocom/bsc/lchan.h:
see also my comment below. It's not valid to have more than one of the vamos, vgcs, vbs booleans set, so it might be better to have an enum or something...
File src/osmo-bsc/abis_rsl.c:
Patch Set #3, Line 408: bool vamos, bool vgcs, bool vbs)
it's a bit odd that we pass multiple separate bool variables in here, where in reality only one of those can be ever set. So either we have to add OSMO_ASSERT() to make sure we never are called with multiple of those bool's set, or we introduce some kind of enum where the caller can chose either VAMOS or VGCS or VBS, but not set multiple at the same time.
To view, visit change 33599. To unsubscribe, or for help writing mail filters, visit settings.