[S] Change in osmo-upf[master]: Improve logging reading packets from gtp device - gerrit-log

28 Jan 2025


      Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-upf/+/39419?usp=email )
Change subject: Improve logging reading packets from gtp device
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-upf/upf_gtpu_echo.c:
https://gerrit.osmocom.org/c/osmo-upf/+/39419/comment/69498832_c061b5d1?usp=... :
PS1, Line 219: return 0;
...
It's just a regular ofd cb, the return code is not really used unless you pass -EBADF. […]
Fine then.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39419?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ic3d9ea319122acbaf99ca7d6ff615b5812a085f8
Gerrit-Change-Number: 39419
Gerrit-PatchSet: 1
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Tue, 28 Jan 2025 19:07:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de