dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-iuh/+/26722
)
Change subject: iu_helpers: make new_transp_info_(rtp|gtp) public
......................................................................
Patch Set 1:
(1 comment)
Patch Set 1:
Let's also merge all this to the new osmo-hnbgw.git (anything related to the new mgw
support).
I will fixup some other stuff and do the AF-agnostic stuff later. I did not know that
there is an osmo-hnbgw.git I will move everything over then.
https://gerrit.osmocom.org/c/osmo-iuh/+/26722/1/include/osmocom/ranap/iu_he…
File include/osmocom/ranap/iu_helpers.h:
https://gerrit.osmocom.org/c/osmo-iuh/+/26722/1/include/osmocom/ranap/iu_he…
PS1, Line 16: RANAP_TransportLayerInformation_t *new_transp_info_rtp(uint32_t ip, uint16_t
port, bool use_x213_nsap);
This looks wrong. […]
Thanks for the input, yes
we seem to support IPv4 at the moment. I think changing this makes sense. I will change it
accordingly, the perhaps also affects the functions I have built on top of this but is
probably better to resolve this now. Sooner or later we will have to support IPv6 anyway.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-iuh/+/26722
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I1e369718de8c4c7db1f1af1e6864562164ada6cf
Gerrit-Change-Number: 26722
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 04 Jan 2022 13:56:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment