Attention is currently required from: neels, fixeria, dexter.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/31176 )
Change subject: support for Ericsson RBS E1 CCU
......................................................................
Patch Set 24:
(2 comments)
File contrib/osmo-pcu.spec.in:
https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/e078a253_259470be
PS24, Line 49: configure
Do we want to build RPM and DEB packages with
`--enable-er-e1-ccu`?
I think we do.
File src/Makefile.am:
https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/ad59b829_09f828dd
PS24, Line 218: EXTRA_DIST
Why do you put `.[ch]` files to `EXTRA_DIST`? This is
unusual.
agreed, c+h files should not be in EXTRA_DIST. EXTRA_DIST is for files that
are not source code but which als should be part of the source files generated by
'make dist'
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/31176
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I5c0a76667339ca984a12cbd2052f5d9e5b0f9c4d
Gerrit-Change-Number: 31176
Gerrit-PatchSet: 24
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 07 Mar 2023 12:58:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment