Attention is currently required from: neels, fixeria, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31176 )
Change subject: support for Ericsson RBS E1 CCU ......................................................................
Patch Set 24:
(2 comments)
File contrib/osmo-pcu.spec.in:
https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/e078a253_259470be PS24, Line 49: configure
Do we want to build RPM and DEB packages with `--enable-er-e1-ccu`?
I think we do.
File src/Makefile.am:
https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/ad59b829_09f828dd PS24, Line 218: EXTRA_DIST
Why do you put `.[ch]` files to `EXTRA_DIST`? This is unusual.
agreed, c+h files should not be in EXTRA_DIST. EXTRA_DIST is for files that are not source code but which als should be part of the source files generated by 'make dist'
-
laforge