Attention is currently required from: jolly.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35076?usp=email )
Change subject: soft_uart: fix pulling a small number of Tx bits
......................................................................
Patch Set 1:
(1 comment)
File src/core/soft_uart.c:
https://gerrit.osmocom.org/c/libosmocore/+/35076/comment/67e603e1_29169a28
PS1, Line 283: osmo_soft_uart_tx_ubits
Looks good to me. Maybe add a check for n_ubits being
0. […]
Ack, thanks! Will do. I think for `n_ubits == 0` we should just return
early.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/35076?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I454c8786697a6f2389d56b350e6e20ca953fe859
Gerrit-Change-Number: 35076
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Tue, 21 Nov 2023 08:18:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>
Gerrit-MessageType: comment