Attention is currently required from: fixeria. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35076?usp=email ) Change subject: soft_uart: fix pulling a small number of Tx bits ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/core/soft_uart.c: https://gerrit.osmocom.org/c/libosmocore/+/35076/comment/c61037c2_b0f69a10 PS1, Line 283: osmo_soft_uart_tx_ubits Looks good to me. Maybe add a check for n_ubits being 0. The current version would request 1 character and provides no bits. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35076?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I454c8786697a6f2389d56b350e6e20ca953fe859 Gerrit-Change-Number: 35076 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas@eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Tue, 21 Nov 2023 08:05:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment