Attention is currently required from: osmith.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/34467?usp=email )
Change subject: sccp: Introduce initial support for SCCP LUDT + LUDTS messages
......................................................................
Patch Set 3:
(1 comment)
File tests/xua/xua_test.ok:
https://gerrit.osmocom.org/c/libosmo-sccp/+/34467/comment/49d0cefd_246368d5
PS2, Line 102: Input != re-encoded output!
is this expected? if so, maybe add a comment about it
like done in the previous patch?
I need to check, I think it's because the
params I'm passing to re-encode it are wrong (not matching the initial msg).
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sccp/+/34467?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ic91abfc921f5e4f36045bfa325333112cddd9fa6
Gerrit-Change-Number: 34467
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Sep 2023 08:56:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment