lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34282 ) Change subject: server_cb: use a define for the VENDOR_3GPP code ...................................................................... server_cb: use a define for the VENDOR_3GPP code Also use a proper variable name Change-Id: I9bd99998963624f7688b972cbb3908fae5686231 --- M src/server_cb.erl 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/82/34282/1 diff --git a/src/server_cb.erl b/src/server_cb.erl index a6450dd..7f30d2b 100644 --- a/src/server_cb.erl +++ b/src/server_cb.erl @@ -6,6 +6,7 @@ -include_lib("diameter_3gpp_ts29_272.hrl"). -include_lib("osmo_gsup/include/gsup_protocol.hrl"). +-define(DIA_VENDOR_3GPP, 10415). %% diameter callbacks -export([peer_up/3, peer_down/3, pick_peer/4, prepare_request/3, prepare_retransmit/3, @@ -177,7 +178,7 @@ -define(GMM_CAUSE_INV_MAND_INFO, 16#60). -define(GMM_CAUSE_PROTO_ERR_UNSPEC, 16#6f). --define(EXP_RES(Foo), #'Experimental-Result'{'Vendor-Id'=10415, 'Experimental-Result-Code'=Foo}). +-define(EXP_RES(Exp), #'Experimental-Result'{'Vendor-Id'=?DIA_VENDOR_3GPP, 'Experimental-Result-Code'=Exp}). -type empty_or_intl() :: [] | [integer()]. -spec gsup_cause2dia(integer()) -> {empty_or_intl(), empty_or_intl()}. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34282 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I9bd99998963624f7688b972cbb3908fae5686231 Gerrit-Change-Number: 34282 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange