fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30583 )

Change subject: fix Speech Codec cfg in BSSMAP Assignment Complete ......................................................................

fix Speech Codec cfg in BSSMAP Assignment Complete

In send_assignment_complete(), obviously return the current channel configuration from lchan->current_ch_mode_rate, which is the proper place to get the channel mode after RSL Chan Activ Ack.

It is interesting to look at the history of this line of code. lchan->current_ch_mode_rate was added later, so now the mistake is very obvious.

Related: SYS#6229 Change-Id: I3bf8f5ea9ae2a3c12fc5b483818d550a069fe66e --- M src/osmo-bsc/assignment_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified

diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c index f00b26d..14944d2 100644 --- a/src/osmo-bsc/assignment_fsm.c +++ b/src/osmo-bsc/assignment_fsm.c @@ -222,7 +222,7 @@ if (gscon_is_aoip(conn)) { /* Extrapolate speech codec from speech mode */ gsm0808_speech_codec_from_chan_type(&sc, perm_spch); - sc.cfg = conn->lchan->activate.ch_mode_rate.s15_s0; + sc.cfg = conn->lchan->current_ch_mode_rate.s15_s0; sc_ptr = ≻ } }