[S] Change in osmo-msc[master]: vlr: add the location update type to the callbacks tx_lu_acc/tx_lu_rej - gerrit-log

14 Oct 2024

Attention is currently required from: pespin.

lynxis lazus has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-msc/+/38407?usp=email )

Change subject: vlr: add the location update type to the callbacks tx_lu_acc/tx_lu_rej
......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2: 
...
  isn't this lu_type information that the
caller/user of the libvlr should know when asking the VLR to […] The lu_type is
already present in the libvlr and the FSMs it has.
Sure the caller could also save this information, but as the FSM has callback to send
PDUs, it would simplify the code.

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38407?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I980a637333e92b15f2d516683feeaded910105b6
Gerrit-Change-Number: 38407
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus &lt;lynxis(a)fe80.eu&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Comment-Date: Mon, 14 Oct 2024 14:41:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;