Attention is currently required from: pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email )
Change subject: fix(threads): centralize portable strerror handling ......................................................................
Patch Set 2:
(2 comments)
File CommonLibs/Threads.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/42199/comment/83120942_26201f44?usp=... : PS1, Line 58: char *err_str = NULL;
wrong indentation
Fixed
https://gerrit.osmocom.org/c/osmo-trx/+/42199/comment/448b737d_ea687898?usp=... : PS1, Line 59: #if defined(__GLIBC__) && defined(_GNU_SOURCE)
Can we move all this into a helper function above so it can be reused? […]
I’ve moved this into Utils as a reusable strerror_buf() helper and added a C++ wrapper strerror_str() based on std::error_code.
-
Timur Davydov