Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39113?usp=email ) Change subject: s1ap_proxy: handle_ies(): pass IEI path to handle_ie() ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/s1ap_proxy.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39113/comment/0f70aee8_d75c… : PS1, Line 122: path = []}}. btw iirc you can set the default values for a type when you declare it (line 71) https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39113/comment/ba43213f_e10b… : PS1, Line 395: when P :: [s1ap_ie_id()], %% Path why not simply renaming the params instead of adding comments? lol -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39113?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I35528a91f7dbf321ad1a0811f1bbcdfb529d3530 Gerrit-Change-Number: 39113 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 20:57:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes