Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39113?usp=email )
Change subject: s1ap_proxy: handle_ies(): pass IEI path to handle_ie() ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/s1ap_proxy.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39113/comment/0f70aee8_d75c3... : PS1, Line 122: path = []}}. btw iirc you can set the default values for a type when you declare it (line 71)
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39113/comment/ba43213f_e10b4... : PS1, Line 395: when P :: [s1ap_ie_id()], %% Path why not simply renaming the params instead of adding comments? lol