[M] Change in osmocom-bb[master]: modem: clean up #includes (using include-what-you-use) - gerrit-log

15 Mar 2023


      fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31655 )
Change subject: modem: clean up #includes (using include-what-you-use)
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS1:
...
Please elaborate on how exactly you've called iwyu - seems like the result is broken for some reason […]
It fails to link the binary (looks like some incompatibility with libtool), but still produces lots of warnings during the compilation stage. I simply addressed these warnings, did `make clean`, and then ran `make` again to make sure the warnings are gone.
-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31655
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I728f3eea1590f46bef6e0eb4beb9714f6c9a1614
Gerrit-Change-Number: 31655
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: msuraev msuraev@sysmocom.de
Gerrit-Comment-Date: Tue, 14 Mar 2023 15:06:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: msuraev msuraev@sysmocom.de
Gerrit-MessageType: comment