Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37010?usp=email ) Change subject: esim.saip: Add ProfileElementSequence.remove_naas_of_type ...................................................................... Patch Set 4: Code-Review+1 (2 comments) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/37010/comment/351326ab_1337481d PS3, Line 562: def remove_naas_of_type(self, naa: Naa) -> None: a list of items that were removed could be returned... but it's not that important, marking as resolved. https://gerrit.osmocom.org/c/pysim/+/37010/comment/b915c31c_68dc1e43 PS3, Line 573: if template in hdr.decoded['eUICC-Mandatory-GFSTEList']: : hdr.decoded['eUICC-Mandatory-GFSTEList'] = [x for x in hdr.decoded['eUICC-Mandatory-GFSTEList'] if not template.prefix_match(x)] I thought if this could possibly miss entries, if `template.prefix_match(x)` is True, but for some reason `template in hdr.decoded[...]` is False. But probably not, nvm. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37010?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I64438bf0be58bad7a561c3744b7e9b1338a7857c Gerrit-Change-Number: 37010 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 10 Jun 2024 08:11:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment