Attention is currently required from: laforge.

Patch set 4:Code-Review +1

View Change

2 comments:

• File pySim/esim/saip/__init__.py:

  • Patch Set #3, Line 562: def remove_naas_of_type(self, naa: Naa) -> None:

    I don't like printing by library functions in general, this kind of code might very well be executed […]

    a list of items that were removed could be returned... but it's not that important, marking as resolved.

  • Patch Set #3, Line 573:

    if template in hdr.decoded['eUICC-Mandatory-GFSTEList']:
                    hdr.decoded['eUICC-Mandatory-GFSTEList'] = [x for x in hdr.decoded['eUICC-Mandatory-GFSTEList'] if not template.prefix_match(x)]
    

    I'm not following you here, sorry.

    I thought if this could possibly miss entries, if `template.prefix_match(x)` is True, but for some reason `template in hdr.decoded[...]` is False. But probably not, nvm.

To view, visit change 37010. To unsubscribe, or for help writing mail filters, visit settings.