Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38328?usp=email ) Change subject: Introduce osmo-udp-responder ...................................................................... Patch Set 1: (1 comment) File src/osmo-udp-responder/udp_responder.c: https://gerrit.osmocom.org/c/upf-benchmark/+/38328/comment/381455a3_1a221c1… : PS1, Line 55: st if we implement our own cmdline parser rather than using glibc getopt_long, I would expect at least some kind of comment on why this is required. So let's please add a comment that explains what this parser does different from getopt_long and why we need it to achieve our goal. -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38328?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: I9edc2e3e1e41767673bcf96f1fe97fa4bf6d60f7 Gerrit-Change-Number: 38328 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 06:00:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No