pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42116?usp=email )
Change subject: xua_asp_fsm: Remove obvious comments ......................................................................
xua_asp_fsm: Remove obvious comments
Those can already be interpretred directly by the ENSURE_* macros. No need to clog the file with more lines describing stuff.
Change-Id: Idec06646c48fbce4cbe200e88f987dfb3e9d5a39 --- M src/xua_asp_fsm.c 1 file changed, 0 insertions(+), 18 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/16/42116/1
diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c index ff83f51..3584b84 100644 --- a/src/xua_asp_fsm.c +++ b/src/xua_asp_fsm.c @@ -552,13 +552,11 @@
switch (event) { case XUA_ASP_E_M_ASP_UP_REQ: - /* only if role ASP */ ENSURE_ASP_OR_IPSP(fi, event); /* Send M3UA_MSGT_ASPSM_ASPUP and start t_ack */ peer_send_and_start_t_ack(fi, XUA_ASP_E_ASPSM_ASPUP); break; case XUA_ASP_E_ASPSM_ASPUP_ACK: - /* only if role ASP */ ENSURE_ASP_OR_IPSP(fi, event); /* Optional ASP Identifier */ if ((asp_id_ie = xua_msg_find_tag(data, SUA_IEI_ASP_ID))) { @@ -570,7 +568,6 @@ send_xlm_prim_simple(fi, OSMO_XLM_PRIM_M_ASP_UP, PRIM_OP_CONFIRM); break; case XUA_ASP_E_ASPSM_ASPUP: - /* only if role SG */ ENSURE_SG_OR_IPSP(fi, event); /* Optional ASP Identifier: Store for NTFY */ if ((asp_id_ie = xua_msg_find_tag(data, SUA_IEI_ASP_ID))) { @@ -585,7 +582,6 @@ PRIM_OP_INDICATION); break; case XUA_ASP_E_ASPSM_ASPDN: - /* only if role SG */ ENSURE_SG_OR_IPSP(fi, event); /* The SGP MUST send an ASP Down Ack message in response * to a received ASP Down message from the ASP even if @@ -655,7 +651,6 @@ send_xlm_prim_simple(fi, OSMO_XLM_PRIM_M_ASP_UP, PRIM_OP_CONFIRM); break; case XUA_ASP_E_ASPTM_ASPAC_ACK: - /* only in role ASP */ ENSURE_ASP_OR_IPSP(fi, event); /* transition state and inform layer manager */ osmo_fsm_inst_state_chg(fi, XUA_ASP_S_ACTIVE, 0, 0); @@ -663,7 +658,6 @@ PRIM_OP_CONFIRM); break; case XUA_ASP_E_ASPSM_ASPDN_ACK: - /* only in role ASP */ ENSURE_ASP_OR_IPSP(fi, event); /* transition state and inform layer manager */ osmo_fsm_inst_state_chg(fi, XUA_ASP_S_DOWN, 0, 0); @@ -672,7 +666,6 @@ break; case XUA_ASP_E_ASPTM_ASPAC: xua_in = data; - /* only in role SG */ ENSURE_SG_OR_IPSP(fi, event); if (xua_msg_find_tag(xua_in, M3UA_IEI_TRAF_MODE_TYP)) { traf_mode = xua_msg_get_u32(xua_in, M3UA_IEI_TRAF_MODE_TYP); @@ -723,7 +716,6 @@ PRIM_OP_INDICATION); break; case XUA_ASP_E_ASPSM_ASPDN: - /* only in role SG */ ENSURE_SG_OR_IPSP(fi, event); /* send ACK */ peer_send(fi, XUA_ASP_E_ASPSM_ASPDN_ACK, NULL); @@ -733,7 +725,6 @@ PRIM_OP_INDICATION); break; case XUA_ASP_E_ASPSM_ASPUP: - /* only if role SG */ ENSURE_SG_OR_IPSP(fi, event); /* If an ASP Up message is received and internally the * remote ASP is already in the ASP-INACTIVE state, an @@ -742,7 +733,6 @@ peer_send(fi, XUA_ASP_E_ASPSM_ASPUP_ACK, NULL); break; case XUA_ASP_E_ASPTM_ASPIA: - /* only in role SG */ ENSURE_SG_OR_IPSP(fi, event); peer_send(fi, XUA_ASP_E_ASPTM_ASPIA_ACK, NULL); break; @@ -780,7 +770,6 @@ send_xlm_prim_simple(fi, OSMO_XLM_PRIM_M_ASP_ACTIVE, PRIM_OP_CONFIRM); break; case XUA_ASP_E_ASPSM_ASPDN_ACK: - /* only in role ASP */ ENSURE_ASP_OR_IPSP(fi, event); osmo_fsm_inst_state_chg(fi, XUA_ASP_S_DOWN, 0, 0); /* inform layer manager */ @@ -788,7 +777,6 @@ PRIM_OP_CONFIRM); break; case XUA_ASP_E_ASPTM_ASPIA_ACK: - /* only in role ASP */ ENSURE_ASP_OR_IPSP(fi, event); osmo_fsm_inst_state_chg(fi, XUA_ASP_S_INACTIVE, 0, 0); /* inform layer manager */ @@ -796,19 +784,16 @@ PRIM_OP_CONFIRM); break; case XUA_ASP_E_M_ASP_DOWN_REQ: - /* only in role ASP */ ENSURE_ASP_OR_IPSP(fi, event); /* send M3UA_MSGT_ASPSM_ASPDN and star t_ack */ peer_send_and_start_t_ack(fi, XUA_ASP_E_ASPSM_ASPDN); break; case XUA_ASP_E_M_ASP_INACTIVE_REQ: - /* only in role ASP */ ENSURE_ASP_OR_IPSP(fi, event); /* send M3UA_MSGT_ASPTM_ASPIA and star t_ack */ peer_send_and_start_t_ack(fi, XUA_ASP_E_ASPTM_ASPIA); break; case XUA_ASP_E_ASPTM_ASPIA: - /* only in role SG */ ENSURE_SG_OR_IPSP(fi, event); /* send ACK */ peer_send(fi, XUA_ASP_E_ASPTM_ASPIA_ACK, NULL); @@ -818,7 +803,6 @@ PRIM_OP_INDICATION); break; case XUA_ASP_E_ASPSM_ASPDN: - /* only in role SG */ ENSURE_SG_OR_IPSP(fi, event); /* send ACK */ peer_send(fi, XUA_ASP_E_ASPSM_ASPDN_ACK, NULL); @@ -828,7 +812,6 @@ PRIM_OP_INDICATION); break; case XUA_ASP_E_ASPSM_ASPUP: - /* only if role SG */ ENSURE_SG_OR_IPSP(fi, event); /* an ASP Up Ack message is returned, as well as * an Error message ("Unexpected Message), and the @@ -842,7 +825,6 @@ break; case XUA_ASP_E_ASPTM_ASPAC: xua_in = data; - /* only in role SG */ ENSURE_SG_OR_IPSP(fi, event); /* send ACK */ peer_send(fi, XUA_ASP_E_ASPTM_ASPAC_ACK, xua_in);
-
pespin