Attention is currently required from: daniel, fixeria, laforge.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41400?usp=email )

Change subject: sccplite: Handle MGCP/CTRL over SCCPLite multiplex using MTP-TRANSFER.req/ind ......................................................................

Patch Set 5:

(2 comments)

File src/osmo-bsc/osmo_bsc_sigtran.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/41400/comment/9294ebb5_1696ab98?usp=... : PS4, Line 466: }

Maybe set `rc` to `-ENODEV` here? Currently you're returning `0`.

Done

File src/osmo-bsc/osmo_bsc_sigtran.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/41400/comment/4f858cd4_9acd5027?usp=... : PS5, Line 799: i

Just to be sure: is this check no longer needed?

For sure it's not needed, because this is some layers below the SAPs used by osmo-bsc.

It's like checking you received a TCP packet from an ethernet interface.