Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email )
Change subject: SGSN_Tests: rework TC_sgsn_context_req_out to actual function
......................................................................
Patch Set 3:
(3 comments)
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017/comment/d14341e7_866d…
:
PS3, Line 3187: // add_rai_oct := rai_to_oct(add_rai);
why is this commented out?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017/comment/ce0a32db_456d…
:
PS3, Line 3200: // [] GTP[GTP_GGSN_IDX].receive(tr_GTPC_SGSNContextReq(g_gn_iface_peer,
tr_SGSNContextReqPDU(rai := rai, ptmsi := ts_PTMSI(ptmsi), ptmsi_sig :=
ts_PTMSI_sig(ptmsi_sig), rat_type := int2oct(enum2int(rat_type), 1)))) -> value
gtpc_pdu {
why is this commented out?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017/comment/694ab21d_93ea…
:
PS3, Line 3311: f_sleep(1.0);
is this really needed?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0666a518aed57c2594653ab6b0f801c4193fd2f3
Gerrit-Change-Number: 39017
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 11 Feb 2025 16:40:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No