Attention is currently required from: laforge, pespin, fixeria.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31533 )
Change subject: common: Have PCU socket connection use osmo_wqueue ......................................................................
Patch Set 6:
(1 comment)
File src/common/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/3641b66d_55fe3863 PS2, Line 1102: osmo_fd_write_disable(&state->upqueue.bfd);
I have looked at some of our projects and seen similar code (code that disables the fd before call […]
I had to rebase/review and resolve merge conflicts. While looking at the code again, I found out that the write disable/enable is handled by the osmo write queue code (which also makes more sense, since the list behind the queue is handled inside that code and not inside `osmo-bts/common/pcu_socket.c` anymore), so I removed it from the write function altogether
-
arehbein