Attention is currently required from: lynxis lazus.
fixeria has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39018?usp=email )
Change subject: SGSN: f_routing_area_update: add authentication argument
......................................................................
Patch Set 9:
(1 comment)
File sgsn/BSSGP_ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39018/comment/3e769ba5_2e79…
:
PS9, Line 691: allow_auth
Maybe add an enumerated type with three values?
```
AUTH_MODE_DISABLED
AUTH_MODE_PERMITTED
AUTH_MODE_REQUIRED
```
Let's imagine I want to make sure there's no authentication. With the current API,
if I pass `allow_auth := false`, the code will still handle authentication despite
it's not expected.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39018?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7125ed8aa81fbda48a19f7f4fc711bc1bf2c875f
Gerrit-Change-Number: 39018
Gerrit-PatchSet: 9
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 25 Aug 2025 17:57:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No