[M] Change in libosmo-gprs[master]: Delay deleting UL TBF until last Pkt Ctrl Ack is fully transmitted - gerrit-log

5 Feb 2024


      Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35775?usp=email )
Change subject: Delay deleting UL TBF until last Pkt Ctrl Ack is fully transmitted
......................................................................
Patch Set 4:
(2 comments)
File src/rlcmac/sched.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/35775/comment/a0434430_85a7d5bf 
PS4, Line 162: TODO
please add the missing doc string
https://gerrit.osmocom.org/c/libosmo-gprs/+/35775/comment/a94f3a31_4b275c55 
PS4, Line 216: //*tbf_to_free = ul_tbf_as_tbf(tbfs->poll_ul_ack);
can this line be removed?
without it, the `tbf_to_free` pointer becomes useless, right?
-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/35775?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: Ic38b4207623ccbda3b77d4b0a47431c25de95034
Gerrit-Change-Number: 35775
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Mon, 05 Feb 2024 12:24:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment