Attention is currently required from: pespin, fixeria, daniel, dexter.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29782 )
Change subject: Introduce support for libosmo-mgcp-client MGW pooling
......................................................................
Patch Set 6: Code-Review+1
(3 comments)
File doc/manuals/chapters/running.adoc:
https://gerrit.osmocom.org/c/osmo-msc/+/29782/comment/ab708559_8c20db0f
PS4, Line 164: had
have
Done
https://gerrit.osmocom.org/c/osmo-msc/+/29782/comment/52119a6c_9ec45945
PS4, Line 165: Hence
(maybe "Therefore", so hence is not used again)
Done
File src/libmsc/call_leg.c:
https://gerrit.osmocom.org/c/osmo-msc/+/29782/comment/cfa51bfc_d25b2709
PS3, Line 20: #include <asm-generic/errno-base.h>
I'm not sure how this ended up here tbh, I'll remove it.
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/29782
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I7670ba56fe989706579224a364595fdd4b4708ff
Gerrit-Change-Number: 29782
Gerrit-PatchSet: 6
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-CC: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: daniel
dwillmann@sysmocom.de
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Tue, 18 Oct 2022 12:08:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith
osmith@sysmocom.de
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Gerrit-MessageType: comment