Attention is currently required from: laforge.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email )

Change subject: tcap: Fix return code in tcap_as_rx_sccp_asp() ......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1:

In my opinion, if the code calls a function that has *tcap* in the name, and the caller passes somet […]

IMHO that function is tcap related (and allows it to quickly find it in tcap related routines files), but as its name indicates it receives a SCCP message and decides if it is TCAP-related, and if that's the case, does stuff with it.

I think it's fine to keep it this way, specially since finding out if it's tcap requires a previous step of decoding SCCP, so better have it in the same path.