Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36148?usp=email ) Change subject: stp: add and use f_m3ua_{cli,srv}_config() helpers ...................................................................... Patch Set 1: (1 comment) File stp/STP_Tests_M3UA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36148/comment/e6b1d78a_113a… PS1, Line 110: mtc.stop; I am not entirely sure if we really need it here. This API is not used in the STP testsuite, I guess because there is simply no complex component hierarchy that would require graceful shutdown. If we still want to use `f_shutdown()` here (e.g. for logging `filename:line`), then the whole STP testsuite needs to me migrated to it (in a separate patch). The `mtc.stop` approach is consistent with the existing code. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36148?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9788f52c20574f4f9d015d2de11b5e42bb03d15f Gerrit-Change-Number: 36148 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Mar 2024 16:19:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment