Attention is currently required from: JPM, dexter.
fixeria has posted comments on this change by JPM. ( https://gerrit.osmocom.org/c/pysim/+/38992?usp=email )
Change subject: Handling Long APDU response ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/38992/comment/6c539209_9610c578?usp=ema... : PS1, Line 7: Handling Long APDU response Please change to `modem_atcmd: Handling Long APDU response` so that the commit message clearly tells where you're adding handling of long APDU response(s).
File pySim/transport/modem_atcmd.py:
https://gerrit.osmocom.org/c/pysim/+/38992/comment/f6631eb8_7682131f?usp=ema... : PS1, Line 172: b'CME ERROR:' You're removing the `+` sign here (was `b'+CME ERROR:'`), is this intentional?
-
fixeria