dexter has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31254 )
Change subject: e1_input: add define constant for full subslot (whole E1 timeslot) ......................................................................
e1_input: add define constant for full subslot (whole E1 timeslot)
The struct gsm_e1_subslot has a memeber e1_ts_ss, which describes the I.460 subslot to use inside an E1 timeslot. This is usually just an integer number (e.g. 0,1,2,3 for a line with 4 16kbps subslots). However it is also possible to use no subslots at all. This is encoded by setting e1_ts_ss to 0xff. When this magic number is used somewhere in the code it is not immediately obvious what it means, so lets add a define constant.
Change-Id: I62725420d1cb2803b87fe5aa5e6ca1f3740be9eb Related: OS#5198 --- M include/osmocom/abis/e1_input.h 1 file changed, 3 insertions(+), 1 deletion(-)
Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved
diff --git a/include/osmocom/abis/e1_input.h b/include/osmocom/abis/e1_input.h index 8e7f20b..91bf181 100644 --- a/include/osmocom/abis/e1_input.h +++ b/include/osmocom/abis/e1_input.h @@ -148,12 +148,14 @@ struct msgb *pending_msg; };
+#define E1_SUBSLOT_FULL 0xff + struct gsm_e1_subslot { /* Number of E1 link */ uint8_t e1_nr; /* Number of E1 TS inside E1 link */ uint8_t e1_ts; - /* Sub-slot within the E1 TS, 0xff if full TS */ + /* Sub-slot within the E1 TS, 0xff (E1_SUBSLOT_FULL) if full TS */ uint8_t e1_ts_ss; };