Attention is currently required from: dexter, laforge.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37499?usp=email )

Change subject: contrib/es9p_client: Add support for reporting notifications to SM-DP+ ......................................................................

Patch Set 3:

(4 comments)

File pySim/esim/__init__.py:

https://gerrit.osmocom.org/c/pysim/+/37499/comment/a126df97_f2fefdbd PS3, Line 7: pmo4operation Looks like you want this to be an `enum.IntEnum`?

``` class PMO(IntEnum): INSTALL = 0x80 ENABLE = 0x40 ... ```

This gives you int/enum conversion API out of box. Not critical.

https://gerrit.osmocom.org/c/pysim/+/37499/comment/bda6ef1e_4d4b1396 PS3, Line 23: _num_bits FYI, this can be implemented as:

* `data.bit_count()` - (Python 3.10 or later) * `bin(data).count("1")` - (Python 3.9 or earlier)

https://gerrit.osmocom.org/c/pysim/+/37499/comment/a84922e9_5535b32e PS3, Line 35: from_int If this class was an `enum.IntEnum`, this API would look like:

``` def from_int(cls, i: int): cls(i) ```

https://gerrit.osmocom.org/c/pysim/+/37499/comment/abbc4c44_b264806c PS3, Line 35: str `str` is not a valid type hint for this function, should be `-> 'PMO'` I think