Attention is currently required from: dexter, laforge.

View Change

4 comments:

• File pySim/esim/__init__.py:

  • Patch Set #3, Line 7: pmo4operation

    Looks like you want this to be an `enum.IntEnum`?

    ```
    class PMO(IntEnum):
        INSTALL = 0x80
        ENABLE = 0x40
        ...
    ```

    This gives you int/enum conversion API out of box.
    Not critical.

  • Patch Set #3, Line 23: _num_bits

    FYI, this can be implemented as:

    • `data.bit_count()` - (Python 3.10 or later)
    • `bin(data).count("1")` - (Python 3.9 or earlier)

  • Patch Set #3, Line 35: from_int

    If this class was an `enum.IntEnum`, this API would look like:

    ```
    def from_int(cls, i: int):
        cls(i)
    ```

  • Patch Set #3, Line 35: str

    `str` is not a valid type hint for this function, should be `-> 'PMO'` I think

To view, visit change 37499. To unsubscribe, or for help writing mail filters, visit settings.