laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38016?usp=email ) Change subject: esim.saip.templates: Fix expand_default_value_pattern for length==0 ...................................................................... esim.saip.templates: Fix expand_default_value_pattern for length==0 The original code treated length==0 like length==None (unspecified), which is wrong. Change-Id: I39fa1e2b1b9d6d1c671ea37bdbec1d6f97e8a5e7 --- M pySim/esim/saip/templates.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/16/38016/1 diff --git a/pySim/esim/saip/templates.py b/pySim/esim/saip/templates.py index 04b2cd4..f69ec7a 100644 --- a/pySim/esim/saip/templates.py +++ b/pySim/esim/saip/templates.py @@ -117,9 +117,9 @@ def expand_default_value_pattern(self, length: Optional[int] = None) -> Optional[bytes]: """Expand the default value pattern to the specified length.""" - if not length: + if length is None: length = self._default_value_len() - if not length: + if length is None: raise ValueError("%s does not have a default length" % self) if not self.default_val: return None -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38016?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I39fa1e2b1b9d6d1c671ea37bdbec1d6f97e8a5e7 Gerrit-Change-Number: 38016 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>