Attention is currently required from: laforge.
Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/30762 )
Change subject: isdn: Add V.110 encoder/decoder
......................................................................
Patch Set 4:
(3 comments)
File src/isdn/v110.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2898):
https://gerrit.osmocom.org/c/libosmocore/+/30762/comment/c7124bf4_97a9235c
PS4, Line 1: /* V.110 frames according to ITU-T V.110
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2898):
https://gerrit.osmocom.org/c/libosmocore/+/30762/comment/cff5420e_9f12f768
PS4, Line 82: ra_bits[2*8 +7] = fr->x_bits[0];
need consistent spacing around '+' (ctx:WxV) (or typedef missing in
osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2898):
https://gerrit.osmocom.org/c/libosmocore/+/30762/comment/cacca063_55ef2a8c
PS4, Line 83: ra_bits[7*8 +7] = fr->x_bits[1];
need consistent spacing around '+' (ctx:WxV) (or typedef missing in
osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/30762
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1b5fd3847d3bfb0a0f763e0574893962ec699680
Gerrit-Change-Number: 30762
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Sat, 21 Jan 2023 21:47:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment