Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30926 )
Change subject: upf/PFCP: do not imply f_inet_addr() ......................................................................
Patch Set 2:
(3 comments)
File hnbgw/HNBGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30926/comment/1a5b60cc_4c547... PS2, Line 1318: var F_SEID up_f_seid := valueof(ts_PFCP_F_SEID_ipv4(f_inet_addr("127.0.0.1"), '1111111111111111'O));
yes i realized that recently, already changed the template. […]
Done
File library/PFCP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30926/comment/6426d596_a09ca... PS2, Line 423: Create_PDR_list create_pdr,
yes but separate patch
Done
File upf/UPF_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30926/comment/48c5681e_08706... PS2, Line 645: PFCP.send(ts_PFCP_Session_Est_Req(ts_PFCP_Node_ID_ipv4(f_inet_addr(g_pars.local_addr)),
nitpick: no need to call f_inet_addr() twice, you can simply store in a local var.
Done
-
neels