Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40271?usp=email )
Change subject: hnbgw: Introduce altstep as_pfcp_handle_del_req()
......................................................................
Patch Set 1:
(2 comments)
File hnbgw/ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40271/comment/7fc00236_ecc0…
:
PS1, Line 998: PFCP.receive(PDU_PFCP:?)
This catch-all `.receive` makes the altstep less useful, because this way it cannot be
used among with other `PFCP.receive` statements / altsteps. If you want it to be
self-contained, then maybe turn it into a generic `f_pfcp_receive()` function with the
timeout.
File hnbgw/HNBGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40271/comment/787fe69b_30a2…
:
PS1, Line 1545: as_pfcp_handle_del_req
Potential side-effect: the new altstep is doing `f_PFCPEM_unsubscribe_seid()`, which was
not here before.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40271?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I94101b5f0ad8634db68f0a9d5230c00926b02061
Gerrit-Change-Number: 40271
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 12 May 2025 09:19:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No