Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36896?usp=email ) Change subject: common: add support for TW-TS-001 ...................................................................... Patch Set 1: (12 comments) File src/common/l1sap.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16235): https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/bcb9c1b8_64c97313 PS1, Line 1998: uint8_t teh; 'teh' may be misspelled - perhaps 'the'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16235): https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/d1802a21_bc319f6a PS1, Line 2003: teh = 0xE0; 'teh' may be misspelled - perhaps 'the'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16235): https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/09c46f74_0b55d5d4 PS1, Line 2005: teh = 0xE2; 'teh' may be misspelled - perhaps 'the'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16235): https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/848fe8cc_61f31b81 PS1, Line 2008: teh = 0xE6; 'teh' may be misspelled - perhaps 'the'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16235): https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/3e1d16df_ae355de3 PS1, Line 2013: teh |= 0x08; 'teh' may be misspelled - perhaps 'the'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16235): https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/1719c13b_81877257 PS1, Line 2015: teh |= 0x01; 'teh' may be misspelled - perhaps 'the'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16235): https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/05608687_536519ec PS1, Line 2017: msgb_push_u8(msg, teh); 'teh' may be misspelled - perhaps 'the'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16235): https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/2d2d3d9d_8b3d11e9 PS1, Line 2020: send_ul_rtp_packet_speech(lchan, fn, &teh, 1); 'teh' may be misspelled - perhaps 'the'? File src/common/rtp_input_preen.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16235): https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/c8288bb0_de6f62a8 PS1, Line 74: /* TEH octet must be correct, and not a BFI */ 'TEH' may be misspelled - perhaps 'THE'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16235): https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/54c04f2c_71cd8e94 PS1, Line 80: /* Strip TEH octet, leaving only standard FR payload. */ 'TEH' may be misspelled - perhaps 'THE'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16235): https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/0dc63208_dade06ad PS1, Line 98: /* TEH octet must be correct, and not a BFI */ 'TEH' may be misspelled - perhaps 'THE'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16235): https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/23da6236_9207b679 PS1, Line 104: /* Strip TEH octet, leaving only standard EFR payload. */ 'TEH' may be misspelled - perhaps 'THE'? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36896?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id997e8666bc19e60936aaa83b43a968d30320bd7 Gerrit-Change-Number: 36896 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 22 May 2024 02:38:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment