Attention is currently required from: pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38410?usp=email )

Change subject: vlr: add a logging layer ......................................................................

Patch Set 4:

(2 comments)

File include/osmocom/vlr/vlr.h:

https://gerrit.osmocom.org/c/osmo-msc/+/38410/comment/e2ad71e1_b7774cea?usp=... : PS2, Line 505: extern int g_vlr_log_cat[_OSMO_VLR_LOGC_MAX];

this should be kept as static (or at least internal to the lib, add a private header if needed.).

Done

https://gerrit.osmocom.org/c/osmo-msc/+/38410/comment/28fbed35_7668e01b?usp=... : PS2, Line 507: #define LOGVLR(lvl, fmt, args...) LOGP(g_vlr_log_cat[OSMO_VLR_LOGC_VLR], lvl, fmt, ## args)

This should also be in private headers.

Done