pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28429 ) Change subject: cbsp: Change log level ERROR->INFO on CBSP tx and link down ...................................................................... cbsp: Change log level ERROR->INFO on CBSP tx and link down Let's decrease the logging since it's fine simply discarding the message if the link is down. This way all code sending messages doesn't need to care about the link state. Change-Id: I64356ec6a7b3a4e11a0e66b17efab2788b1ca5cc --- M src/osmo-bsc/cbsp_link.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/cbsp_link.c b/src/osmo-bsc/cbsp_link.c index d8c32ec..849b802 100644 --- a/src/osmo-bsc/cbsp_link.c +++ b/src/osmo-bsc/cbsp_link.c @@ -301,7 +301,7 @@ struct msgb *msg; if (!cbc->client.cli && !cbc->server.srv) { - LOGP(DCBS, LOGL_ERROR, "Discarding Tx CBSP Message Type %s, link is down\n", + LOGP(DCBS, LOGL_INFO, "Discarding Tx CBSP Message Type %s, link is down\n", get_value_string(cbsp_msg_type_names, cbsp->msg_type)); talloc_free(cbsp); return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I64356ec6a7b3a4e11a0e66b17efab2788b1ca5cc Gerrit-Change-Number: 28429 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged