Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30620 )
Change subject: Convert tbf->control_ts to be a gprs_rlcmac_pdch* ......................................................................
Patch Set 2:
(2 comments)
File src/pdch.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/30620/comment/69110a5b_dbe74e5a PS2, Line 1316: ts == pdch Same here: comparing foo_ts to pdch may look confusing, so it's better to have a unified naming by doing s/_ts/_pdch/.
File tests/alloc/AllocTest.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/30620/comment/d1481da6_22451d8d PS2, Line 186: tbf->control_ts Maybe move NULL checking to pdch_name()? This way one could pass PDCH pointers directly without worrying if it's NULL.
-
fixeria