Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27309 )

Change subject: inter-BSC HO in: add Speech Codec (Chosen) IE to HO Req Ack ......................................................................

Patch Set 1: Code-Review-1

(1 comment)

File src/osmo-bsc/osmo_bsc_bssap.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/27309/comment/abea5aba_2f76e018 PS1, Line 1449: return HO_RESULT_ERROR Everywhere in this function I see -ERRNO returned, but here you return a positive integer from 'enum handover_result'. Then in ho_fsm_wait_rr_ho_detect_onenter() we're calling strerror(-rc). The error message in this case may look really confusing, so I suggest to use -ERRNO here too.