Attention is currently required from: falconia.
fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/41048?usp=email )
Change subject: FR/HR/EFR: centralize TCH UL SID classification ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/41048/comment/843d933e_8e3bda70?usp=... : PS2, Line 2358: /* This static function should never be called except for : * V1 and EFR speech modes. */ :
If we were to call `tch_ul_fr_hr_efr()` from `l1sap_tch_ind()` unconditionally like you suggest, the […]
I guess you mean the code you're adding in a follow-up patch, resetting `ul_sid_filter`? My suggestion arose before I saw next patches :) Makes sense, I am fine keeping it as-is.
-
fixeria