Change in pysim[master]: pySim-shell: make APDU command available on the lowest level - gerrit-log

1 Jun 2022

Attention is currently required from: laforge.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28163 )

Change subject: pySim-shell: make APDU command available on the lowest level
......................................................................

Patch Set 3:

(2 comments)

File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/28163/comment/ca1bcdfe_665f9ece 
PS1, Line 227:             if (self.card):
...
  I think in python you don't usually put
parenthesis around a single condition in an if statement, se […] Done

https://gerrit.osmocom.org/c/pysim/+/28163/comment/43a58a97_a641cf5b 
PS1, Line 257:         if (data):
...
  same here. "if data:" should do the trick.
Done

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/28163
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I601b8f17bd6af41dcbf7bbb53c75903dd46beee7
Gerrit-Change-Number: 28163
Gerrit-PatchSet: 3
Gerrit-Owner: dexter &lt;pmaier(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Comment-Date: Wed, 01 Jun 2022 15:59:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-MessageType: comment