Attention is currently required from: Hoernchen, Timur Davydov, fixeria, laforge, osmith.

pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email )

Change subject: build: install common/GSM/transceiver libraries for emscripten and add pkg-config files ......................................................................

Patch Set 3:

(5 comments)

File CommonLibs/Makefile.am:

https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/32d0c1e0_84eec133?usp=... : PS3, Line 56: lib_LTLIBRARIES = libcommon.la By doing this, you are installing the libraries, which is something we don't wanna do.

File GSM/Makefile.am:

https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/c6e2181f_a4fd25ed?usp=... : PS3, Line 29: gsm_headers = \ You are now also installing headers which shouldn't be installed afaiu.

File configure.ac:

https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/cffc163a_9ac32661?usp=... : PS3, Line 82: AC_DISABLE_SHARED dnl don't build shared libraries (emscripten) I changed this, see my patchset in https://gerrit.osmocom.org/c/osmo-trx/+/42252/

https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/e94559b7_a07b4618?usp=... : PS3, Line 306: PKG_CHECK_MODULES(LIBUSB, libusb-1.0) See "https://gerrit.osmocom.org/c/osmo-trx/+/42255 Drop libusb dependency"

https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/1382e3c6_37796f00?usp=... : PS3, Line 307: PKG_CHECK_MODULES(FFTWF, fftw3f) fftw3.h is being included in Transceiver52M/arch/common/fft.c , and then fft.h is being included by:

Transceiver52M/Channelizer.cpp 33:#include "fft.h"

Transceiver52M/ChannelizerBase.cpp 34:#include "fft.h"

Transceiver52M/ChannelizerBase.h 22: struct fft_hdl *fftHandle;

Transceiver52M/Synthesis.cpp 34:#include "fft.h"

How are you supposed to be building without all that?