falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/38304?usp=email ) Change subject: csd_v110: set E2 bit correctly for TCH/F4.8 NT ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Disclaimer: I currently have no way to test any CSD functionality or anything else that requires osmo-bts-trx; this patch has been implemented "from theory only". However, the current code is known to be wrong (E2 is always 0), whereas the new code stands at least a chance of being correct. In any case, I would appreciate it if someone can test it. If someone can run a test setup and send me pcap of the RTP output, I can analyze that pcap myself to verify correctness of E-bits. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38304?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1e0ad58aad3361b3a2b0a47113bd065587636730 Gerrit-Change-Number: 38304 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 27 Sep 2024 03:24:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No