Attention is currently required from: fixeria, pespin, dexter. Hello Jenkins Builder, laforge, pespin, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/27430 to look at the new patch set (#5). Change subject: osmo-bts-trx: rx_tchh_fn(): fix HR SID detection (wrong offset) ...................................................................... osmo-bts-trx: rx_tchh_fn(): fix HR SID detection (wrong offset) According to ETSI TS 101 318, section 5.2, the GSM half rate codec has frame length of 14 bytes (112 bits). According to RFC5993, which is referenced by 3GPP TS 48.103, the complete RTP payload consists of a payload Table-of-Contents (ToC) byte followed by the 14 bytes of the HR codec frame. See section 5.2. gsm0503_tch_hr_decode() outputs frames in the RTP format with length of 15 bytes (120 bits): 1 (ToC) + 14 (HR frame): +-------------+------------------------- | ToC section | HR codec frame ... +-------------+------------------------- osmo_hr_check_sid() expects a HR codec frame of 14 bytes (112 bits) as the input, so we should skip the ToC section when calling it. Change-Id: Ie5fa776dcb2b2203a97aed56ecbf2450af7d87c1 Related: SYS#5853 --- M src/osmo-bts-trx/sched_lchan_tchh.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/30/27430/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie5fa776dcb2b2203a97aed56ecbf2450af7d87c1 Gerrit-Change-Number: 27430 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset