Attention is currently required from: laforge.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31967 )
Change subject: contrib: Add BER testing tool ......................................................................
Patch Set 5:
(6 comments)
File contrib/ber/rtp_ber.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5283): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/edd3f02b_01ef9e7d PS5, Line 97: static const char *amr_rate_by_ft[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5283): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/4286c66d_5e80a89a PS5, Line 416: if (rtp_seq_num_diff(seq_number, as->rx_last_seq) > 1) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5283): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/f3e64c2b_b9415de8 PS5, Line 480: while (1) { braces {} are not necessary for single statement blocks
File contrib/ber/rtp_gen_map.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5283): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/a9d55c68_e2e1c091 PS5, Line 34: for (i = 0; i < 260; i++) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5283): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/1b4865eb_7106480a PS5, Line 55: for (i = 0; i < 260; i++) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5283): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/6cd05174_b21ee4ef PS5, Line 116: for (i = 0; i < len; i++) that open brace { should be on the previous line
-
Jenkins Builder