pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27973 )
Change subject: paging: Early stop work_timer when paging queue becomes empty ......................................................................
paging: Early stop work_timer when paging queue becomes empty
There's no need to keep the timer running, since anyway upon next trigger it will simply early exit in paging_handle_pending_requests() becuase there's no more work to do.
Change-Id: I096ab7231f52c741c5fded37acd5b309e1de06e3 --- M src/osmo-bsc/paging.c 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved
diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c index f2bcf96..fcb038b 100644 --- a/src/osmo-bsc/paging.c +++ b/src/osmo-bsc/paging.c @@ -84,6 +84,8 @@ llist_del(&to_be_deleted->entry); bsc_subscr_put(to_be_deleted->bsub, BSUB_USE_PAGING_REQUEST); talloc_free(to_be_deleted); + if (llist_empty(&paging_bts->pending_requests)) + osmo_timer_del(&paging_bts->work_timer); }
static void page_ms(struct gsm_paging_request *request)